From 11534ec5b6cea13ae38d31799d2a5290c5d724af Mon Sep 17 00:00:00 2001 From: Kamalesh Babulal Date: Sat, 10 Dec 2011 19:29:25 +0530 Subject: [PATCH] sched: Remove cfs bandwidth period check in tg_set_cfs_period() Remove cfs bandwidth period check from tg_set_cfs_period. Invalid bandwidth period's lower/upper limits are denoted by min_cfs_quota_period/max_cfs_quota_period repsectively, and are checked against valid period in tg_set_cfs_bandwidth(). As pjt pointed out, negative input will result in very large unsigned numbers and will be caught by the max allowed period test. Signed-off-by: Kamalesh Babulal Acked-by: Paul Turner [ammended changelog to mention negative values] Signed-off-by: Peter Zijlstra Link: http://lkml.kernel.org/r/20111210135925.GA14593@linux.vnet.ibm.com -- kernel/sched/core.c | 3 --- 1 file changed, 3 deletions(-) Signed-off-by: Ingo Molnar --- kernel/sched/core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index dba878c73a08..081ece26803f 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -7714,9 +7714,6 @@ int tg_set_cfs_period(struct task_group *tg, long cfs_period_us) period = (u64)cfs_period_us * NSEC_PER_USEC; quota = tg->cfs_bandwidth.quota; - if (period <= 0) - return -EINVAL; - return tg_set_cfs_bandwidth(tg, period, quota); } -- 2.45.2