From 14a36ae70429f2872a8f750c60c75d14862761dc Mon Sep 17 00:00:00 2001 From: Alex Elder Date: Fri, 3 Jun 2016 15:55:34 -0500 Subject: [PATCH] greybus: tracing: assign "parent" id first Most abstractions to be traced will have a sort of "parent" object it is associated with, and an identifier for that parent is stored with the as trace event data. For example, the parent of a message is the operation it's a part of, and the parent of an operation is the connection it uses. We'll arrange to define that parent id first in all events. Most abstractions already do this. Move an interface's module id so it's defined and assigned first. The message traces are going to be changed soon, so leave that one alone. Signed-off-by: Alex Elder Reviewed-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/greybus_trace.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/greybus_trace.h b/drivers/staging/greybus/greybus_trace.h index 9d38cb31f81f..5ecb504f0f65 100644 --- a/drivers/staging/greybus/greybus_trace.h +++ b/drivers/staging/greybus/greybus_trace.h @@ -168,8 +168,8 @@ DECLARE_EVENT_CLASS(gb_interface, TP_ARGS(intf), TP_STRUCT__entry( - __field(u8, id) /* Interface id */ __field(u8, module_id) + __field(u8, id) /* Interface id */ __field(u8, device_id) __field(int, disconnected) /* bool */ __field(int, ejected) /* bool */ @@ -178,8 +178,8 @@ DECLARE_EVENT_CLASS(gb_interface, ), TP_fast_assign( - __entry->id = intf->interface_id; __entry->module_id = intf->module->module_id; + __entry->id = intf->interface_id; __entry->device_id = intf->device_id; __entry->disconnected = intf->disconnected; __entry->ejected = intf->ejected; -- 2.45.2