From 1682b42b87f441cf1e80ec72e82eecf1726eb99b Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Mon, 28 Nov 2011 19:23:43 +0000 Subject: [PATCH] Tiny patch from Martin Packman to fix a Windows handle leak in Pageant's IPC mechanism. It's incomplete (he sent a much more comprehensive set of fixes that I haven't reviewed), but should be adequate to mitigate a particular issue for Bazaar users. [originally from svn r9355] --- windows/winpgnt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/windows/winpgnt.c b/windows/winpgnt.c index e26621c7..291593e4 100644 --- a/windows/winpgnt.c +++ b/windows/winpgnt.c @@ -1938,8 +1938,10 @@ static LRESULT CALLBACK WndProc(HWND hwnd, UINT message, } #endif if (!EqualSid(mapowner, ourself) && - !EqualSid(mapowner, ourself2)) + !EqualSid(mapowner, ourself2)) { + CloseHandle(filemap); return 0; /* security ID mismatch! */ + } #ifdef DEBUG_IPC debug(("security stuff matched\n")); #endif -- 2.45.2