From 1878c5b91430d38a0beefd0dc5cb6035913ebc7f Mon Sep 17 00:00:00 2001 From: Christophe JAILLET Date: Sat, 2 Nov 2019 16:59:45 +0100 Subject: [PATCH] staging: wfx: Fix a memory leak in 'wfx_upload_beacon' The current code is a no-op, because all it can do is 'dev_kfree_skb(NULL)' Remove the test before 'dev_kfree_skb()' Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/20191102155945.20205-1-christophe.jaillet@wanadoo.fr Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wfx/sta.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 688586e823c0..93f3739b5f3a 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -906,8 +906,7 @@ static int wfx_upload_beacon(struct wfx_vif *wvif) wfx_fwd_probe_req(wvif, false); done: - if (!skb) - dev_kfree_skb(skb); + dev_kfree_skb(skb); return ret; } -- 2.45.2