From 1deeb6408c1ca9ee2ebb0ee8e0a7ba7c6fadf397 Mon Sep 17 00:00:00 2001 From: David Ahern Date: Fri, 12 Apr 2019 10:31:14 -0700 Subject: [PATCH] ipv6: Remove flowi6_oif compare from __ip6_route_redirect In the review of 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect"), Martin noted that the flowi6_oif compare is moved to the new helper and should be removed from __ip6_route_redirect. Fix the oversight. Fixes: 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect") Reported-by: Martin Lau Signed-off-by: David Ahern Signed-off-by: David S. Miller --- net/ipv6/route.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index d555edaaff13..a77c004d67fb 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2471,8 +2471,6 @@ static struct rt6_info *__ip6_route_redirect(struct net *net, continue; if (rt->fib6_flags & RTF_REJECT) break; - if (fl6->flowi6_oif != rt->fib6_nh.fib_nh_dev->ifindex) - continue; if (ip6_redirect_nh_match(rt, &rt->fib6_nh, fl6, &rdfl->gateway, &ret)) goto out; -- 2.45.2