From 3302603e14838b19e41c46cbc400debfe95451db Mon Sep 17 00:00:00 2001 From: Narcisa Ana Maria Vasile Date: Wed, 1 Mar 2017 17:37:27 +0200 Subject: [PATCH] staging: vc04_services: bcm2835-camera: Remove unnecessary variable Instead of storing the result, make the function return directly Signed-off-by: Narcisa Ana Maria Vasile Signed-off-by: Greg Kroah-Hartman --- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index 53e275e70274..84650d9a8d06 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -671,7 +671,6 @@ static struct vb2_ops bm2835_mmal_video_qops = { static int set_overlay_params(struct bm2835_mmal_dev *dev, struct vchiq_mmal_port *port) { - int ret; struct mmal_parameter_displayregion prev_config = { .set = MMAL_DISPLAY_SET_LAYER | MMAL_DISPLAY_SET_ALPHA | MMAL_DISPLAY_SET_DEST_RECT | MMAL_DISPLAY_SET_FULLSCREEN, @@ -685,11 +684,9 @@ static int set_overlay_params(struct bm2835_mmal_dev *dev, .height = dev->overlay.w.height, }, }; - ret = vchiq_mmal_port_parameter_set(dev->instance, port, - MMAL_PARAMETER_DISPLAYREGION, - &prev_config, sizeof(prev_config)); - - return ret; + return vchiq_mmal_port_parameter_set(dev->instance, port, + MMAL_PARAMETER_DISPLAYREGION, + &prev_config, sizeof(prev_config)); } /* overlay ioctl */ -- 2.45.2