From 42c5814c9c9828a7fcbe25f69c5c8cbbf29ed957 Mon Sep 17 00:00:00 2001 From: Guenter Roeck Date: Mon, 12 Jan 2015 21:12:17 -0800 Subject: [PATCH] next: drm/atomic: Use copy_from_user to copy 64 bit data from user space Copying 64 bit data from user space using get_user is not supported on all architectures, and may result in the following build error. ERROR: "__get_user_bad" [drivers/gpu/drm/drm.ko] undefined! Avoid the problem by using copy_from_user. Fixes: d34f20d6e2f2 ("drm: Atomic modeset ioctl") Cc: Rob Clark Signed-off-by: Guenter Roeck Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 1e38dfc8e462..af3f3dfdb49f 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1259,7 +1259,9 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, goto fail; } - if (get_user(prop_value, prop_values_ptr + copied_props)) { + if (copy_from_user(&prop_value, + prop_values_ptr + copied_props, + sizeof(prop_value))) { ret = -EFAULT; goto fail; } -- 2.45.2