From 589b1f7e4b0db4c31cef3b55f7514857bfc4b093 Mon Sep 17 00:00:00 2001 From: YueHaibing Date: Wed, 25 Apr 2018 19:27:07 +0800 Subject: [PATCH] powerpc/xics: Add missing of_node_put() in error path The device node obtained with of_find_compatible_node() should be released by calling of_node_put(). But it was not released when of_get_property() failed. Signed-off-by: YueHaibing [mpe: Invert the sense of the if so we only need one return path] Signed-off-by: Michael Ellerman --- arch/powerpc/sysdev/xics/xics-common.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/sysdev/xics/xics-common.c b/arch/powerpc/sysdev/xics/xics-common.c index 77e864d5506d..f87470319d71 100644 --- a/arch/powerpc/sysdev/xics/xics-common.c +++ b/arch/powerpc/sysdev/xics/xics-common.c @@ -446,10 +446,11 @@ static void __init xics_get_server_size(void) np = of_find_compatible_node(NULL, NULL, "ibm,ppc-xics"); if (!np) return; + isize = of_get_property(np, "ibm,interrupt-server#-size", NULL); - if (!isize) - return; - xics_interrupt_server_size = be32_to_cpu(*isize); + if (isize) + xics_interrupt_server_size = be32_to_cpu(*isize); + of_node_put(np); } -- 2.45.2