From 6561e82d93e12744f1fa2048b6a17e5739682749 Mon Sep 17 00:00:00 2001 From: Meghana Madhyastha Date: Fri, 15 Sep 2017 14:43:15 +0530 Subject: [PATCH] Staging: irda: drivers: Replace (skb == NULL) with (!skb) Some functions return NULL as an indication of failure. The style (!skb) is more common than (skb == NULL) for these functions. Found by the following Coccinelle script. @@ identifier i; statement S; @@ i = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|usb_alloc_urb\| alloc_netdev\|dev_alloc_skb\)(...)); ( -if (i == NULL) +if (!i) S | -if (NULL == i) +if (!i) S ) Signed-off-by: Meghana Madhyastha Signed-off-by: Greg Kroah-Hartman --- drivers/staging/irda/drivers/ali-ircc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/irda/drivers/ali-ircc.c b/drivers/staging/irda/drivers/ali-ircc.c index 35f198d83701..756ae53dc1ec 100644 --- a/drivers/staging/irda/drivers/ali-ircc.c +++ b/drivers/staging/irda/drivers/ali-ircc.c @@ -1876,7 +1876,7 @@ static int ali_ircc_dma_receive_complete(struct ali_ircc_cb *self) self->stamp = ktime_get(); skb = dev_alloc_skb(len+1); - if (skb == NULL) + if (!skb) { self->netdev->stats.rx_dropped++; -- 2.45.2