From adc8139e687ed58548a92cda541d10c57212cd38 Mon Sep 17 00:00:00 2001 From: Zhan liu Date: Mon, 25 Nov 2019 17:25:18 -0500 Subject: [PATCH] drm/amd/display: Modify comments to match the code [Why] This line of code was modified. However, comments remained unchanged. As a result, comments and code are mismatching. [How] Modifying comments to reflect code. At the same time, explaining why the value was changed from 200ms to 3000ms. Signed-off-by: Zhan Liu Reviewed-by: Nicholas Kazlauskas Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dc_helper.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc_helper.c b/drivers/gpu/drm/amd/display/dc/dc_helper.c index 8da4576e2908..e41befa067ce 100644 --- a/drivers/gpu/drm/amd/display/dc/dc_helper.c +++ b/drivers/gpu/drm/amd/display/dc/dc_helper.c @@ -485,7 +485,12 @@ void generic_reg_wait(const struct dc_context *ctx, return; } - /* something is terribly wrong if time out is > 200ms. (5Hz) */ + /* + * Something is terribly wrong if time out is > 3000ms. + * 3000ms is the maximum time needed for SMU to pass values back. + * This value comes from experiments. + * + */ ASSERT(delay_between_poll_us * time_out_num_tries <= 3000000); for (i = 0; i <= time_out_num_tries; i++) { -- 2.45.2