From bc47e84258be3e49c14be65a111f2117ecc986f6 Mon Sep 17 00:00:00 2001 From: kbuild test robot Date: Mon, 2 May 2016 11:50:16 -0400 Subject: [PATCH] md-cluster: fix ifnullfree.cocci warnings drivers/md/bitmap.c:2049:6-11: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Acked-by: Guoqing Jiang Signed-off-by: Fengguang Wu Signed-off-by: Shaohua Li --- drivers/md/bitmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c index 4a05bacd6601..ad5a85847004 100644 --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c @@ -2076,8 +2076,7 @@ int bitmap_resize(struct bitmap *bitmap, sector_t blocks, /* deallocate the page memory */ for (k = 0; k < page; k++) { - if (new_bp[k].map) - kfree(new_bp[k].map); + kfree(new_bp[k].map); } /* restore some fields from old_counts */ -- 2.45.2