From c95d2e87fca1402e1a6a2a8577bf78abd401671f Mon Sep 17 00:00:00 2001 From: Gargi Sharma Date: Tue, 7 Mar 2017 23:50:27 +0530 Subject: [PATCH] staging: gdm724x: Replace ternary operator with min macro Use macro min() to get the minimum of two values for brevity and readability. The macro MUX_TX_MAX_SIZE has a value of 2048 which is well within the integer limits. This check was done manually. Found using Coccinelle: @@ type T; T x; T y; @@ ( - x < y ? x : y + min(x,y) | - x > y ? x : y + max(x,y) ) Signed-off-by: Gargi Sharma Signed-off-by: Greg Kroah-Hartman --- drivers/staging/gdm724x/gdm_tty.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c index ae396638f897..fc7682c18f20 100644 --- a/drivers/staging/gdm724x/gdm_tty.c +++ b/drivers/staging/gdm724x/gdm_tty.c @@ -190,8 +190,7 @@ static int gdm_tty_write(struct tty_struct *tty, const unsigned char *buf, return 0; while (1) { - sending_len = remain > MUX_TX_MAX_SIZE ? MUX_TX_MAX_SIZE : - remain; + sending_len = min(MUX_TX_MAX_SIZE, remain); gdm_tty_send(gdm, (void *)(buf + sent_len), sending_len, -- 2.45.2