From e5b811e38af7540b385c898d83eb0198310343fd Mon Sep 17 00:00:00 2001 From: Al Viro Date: Sun, 8 Mar 2015 23:36:51 -0400 Subject: [PATCH] drop bogus check in file_open_root() For one thing, LOOKUP_DIRECTORY will be dealt with in do_last(). For another, name can be an empty string, but not NULL - no callers pass that and it would oops immediately if they would. Signed-off-by: Al Viro --- fs/open.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/open.c b/fs/open.c index 33f9cbf2610b..ebcc7df0c9b6 100644 --- a/fs/open.c +++ b/fs/open.c @@ -988,9 +988,6 @@ struct file *file_open_root(struct dentry *dentry, struct vfsmount *mnt, return ERR_PTR(err); if (flags & O_CREAT) return ERR_PTR(-EINVAL); - if (!filename && (flags & O_DIRECTORY)) - if (!dentry->d_inode->i_op->lookup) - return ERR_PTR(-ENOTDIR); return do_file_open_root(dentry, mnt, filename, &op); } EXPORT_SYMBOL(file_open_root); -- 2.45.2