From eb76b37aaf7e6bdd6638bf5b2ef29688645e03b8 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Tue, 19 Feb 2019 13:43:33 +0000 Subject: [PATCH] usb: typec: mux: remove redundant check on variable match All the code paths that lead to the return statement are where match is always true, hence the check to see if it is true is redundant and can be removed. Detected by CoverityScan, CID#14769672 ("Logically dead code") Signed-off-by: Colin Ian King Acked-by: Heikki Krogerus Signed-off-by: Greg Kroah-Hartman --- drivers/usb/typec/mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/mux.c b/drivers/usb/typec/mux.c index 54d74978df9c..2ce54f3fc79c 100644 --- a/drivers/usb/typec/mux.c +++ b/drivers/usb/typec/mux.c @@ -184,7 +184,7 @@ static void *typec_mux_match(struct device_connection *con, int ep, void *data) if (dev_fwnode(mux->dev) == con->fwnode) return mux; - return match ? ERR_PTR(-EPROBE_DEFER) : NULL; + return ERR_PTR(-EPROBE_DEFER); } /** -- 2.45.2