From ffe57033008ba7b09f1319ea0f7fb8d91624046a Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Tue, 12 Jul 2016 08:00:55 -0300 Subject: [PATCH] [media] VPU: mediatek: fix return value check in mtk_vpu_probe() In case of error, the function devm_clk_get() returns ERR_PTR() and not returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/mtk-vpu/mtk_vpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c index b60d02c0f653..c8b2c72e7c48 100644 --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c @@ -788,9 +788,9 @@ static int mtk_vpu_probe(struct platform_device *pdev) /* Get VPU clock */ vpu->clk = devm_clk_get(dev, "main"); - if (!vpu->clk) { + if (IS_ERR(vpu->clk)) { dev_err(dev, "get vpu clock failed\n"); - return -EINVAL; + return PTR_ERR(vpu->clk); } platform_set_drvdata(pdev, vpu); -- 2.45.2