From 67ff21ebd164df650341715ed83fc60c0e642d64 Mon Sep 17 00:00:00 2001 From: Scott McKay Date: Thu, 13 Jun 2013 19:37:58 +0530 Subject: [PATCH] Add a to-do comment (low pri) and a bit of missing whitespace --- serialize.lisp | 2 ++ utilities.lisp | 1 + 2 files changed, 3 insertions(+) diff --git a/serialize.lisp b/serialize.lisp index 178d34b..eea0924 100644 --- a/serialize.lisp +++ b/serialize.lisp @@ -346,6 +346,8 @@ (serialization-error "Error deserializing buffer ~S: ~A" buffer (princ-to-string e)))))) ;; The default method uses metadata from the protobuf "schema" for the message +;;--- Maybe complain if there were any unsent required fields (see 'object-initialized-p'), +;;--- but Lisp itself will complain if you try to access them, so not critical (defmethod deserialize-object ((message protobuf-message) buffer &optional start end (end-tag 0)) (declare (type (simple-array (unsigned-byte 8)) buffer)) (let ((index (or start 0)) diff --git a/utilities.lisp b/utilities.lisp index 512a9f8..c548ed4 100644 --- a/utilities.lisp +++ b/utilities.lisp @@ -75,6 +75,7 @@ (defmacro ilogbitp (index integer) `(logbitp ,index (the fixnum ,integer))) + ;;; String utilities (defun starts-with (string prefix &key (start 0)) -- 2.45.2